initiate_wait_for_task - support :flash => true to flash while waiting #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while waiting for a task, we sometimes want to show a flash indicating the UI is waiting fro the task to finish
this allows us to use something like..
```
add_flash(_("Task queued"))
initiate_wait_work_task(..., :flash => true)
```
and expect a flash message to be shown under the spinner
|
@himdel thank you |
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/78f8bce31bd02633fb9084abc25e97a475141b86 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while waiting for a task, we sometimes want to show a flash indicating the UI is waiting fro the task to finish
this allows us to use something like..
and expect a flash message to be shown under the spinner
Comes from a discussion in #4628, cc @yrudman
Note this will eat any queued flash messages (which is probably ok, since any success/error messages should come from the
:action).